feature(hoppscotch): allow resources on default init containers - #69
Merged
Conversation
nahidhasan94
requested review from
mirarifhasan
and
a lite review from Copilot
August 13, 2026 08:33
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Hoppscotch Helm chart so the default init containers (wait-for-db and wait-for-migrations) always have configurable CPU/memory resources via the same resourcesPreset/resources pattern used elsewhere in the chart, improving compatibility with clusters enforcing ResourceQuota requirements.
Changes:
- Added
resourcesPreset+resourcesvalues for both default init containers (defaults:nanofor DB wait,smallfor migrations wait). - Rendered
resources:blocks for both init containers using the sharedhoppscotch.resourceshelper. - Added helm-unittest coverage for default preset rendering and explicit resource overrides; regenerated README docs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/hoppscotch/values.yaml | Adds configurable resourcesPreset/resources for both default init containers with sane defaults. |
| charts/hoppscotch/templates/_default_init_containers.tpl | Emits resources: blocks for both init containers via the shared hoppscotch.resources helper. |
| charts/hoppscotch/tests/default_init_container_wait_for_database_test.yaml | Verifies the nano preset resources are applied by default and that explicit overrides win. |
| charts/hoppscotch/tests/default_init_container_wait_for_migrations_test.yaml | Verifies the small preset resources are applied by default and that explicit overrides win. |
| charts/hoppscotch/README.md | Documents the new values (and updates chart/app version badges as part of regeneration). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mirarifhasan
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
wait-for-dbandwait-for-migrationsdefault init containers didn't set anyCPU/memory resources and couldn't be configured via values. On clusters with a
ResourceQuotathat requires requests/limits on every container (standard on OpenShift,common on hardened Kubernetes), pod admission failed and the chart wouldn't deploy:
Every other container in the chart already exposes
resourcesPreset/resources; thedefault init containers were the only exception.
Changes
resourcesPresetandresourcestodefaultInitContainers.waitForDatabase(
nano) anddefaultInitContainers.waitForMigrations(small).resources:block in both init containers viahoppscotch.resources, matchinghow the other components do it.
waitForMigrationsuses thesmallpreset (512Mi) soprisma migrate statushas thesame headroom as the migrations Job;
waitForDatabasestaysnano(pg_isready).regenerated.
Test plan
helm lint+helm unittestpass (init-container suites green)helm templateshowsresourceson both init containersResourceQuota(verified on OpenShiftrestricted-v2, AIO + distributed)